linux-kernel - Re: [PATCH 2/4] ACPI / platform: provide default DMA mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487657.QLes1WRKBI@vostro.rjw.lan>
Date:	Tue, 23 Sep 2014 16:52:01 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Felipe Balbi <balbi@...com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/4] ACPI / platform: provide default DMA mask

On Tuesday, September 23, 2014 03:17:12 PM Heikki Krogerus wrote:
> On Wed, Aug 20, 2014 at 02:55:26PM +0300, Heikki Krogerus wrote:
> > Most devices are configured for 32-bit DMA addresses.
> > Setting the mask to 32-bit here removes the need for the
> > drivers to do it separately.
> 
> Rafael, is this OK?

Fine by me, but it should go in via dwc3 I think.

> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > ---
> >  drivers/acpi/acpi_platform.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> > index 2bf9082..8d099e6 100644
> > --- a/drivers/acpi/acpi_platform.c
> > +++ b/drivers/acpi/acpi_platform.c
> > @@ -16,6 +16,7 @@
> >  #include <linux/err.h>
> >  #include <linux/kernel.h>
> >  #include <linux/module.h>
> > +#include <linux/dma-mapping.h>
> >  #include <linux/platform_device.h>
> >  
> >  #include "internal.h"
> > @@ -102,6 +103,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
> >  	pdevinfo.res = resources;
> >  	pdevinfo.num_res = count;
> >  	pdevinfo.acpi_node.companion = adev;
> > +	pdevinfo.dma_mask = DMA_BIT_MASK(32);
> >  	pdev = platform_device_register_full(&pdevinfo);
> >  	if (IS_ERR(pdev))
> >  		dev_err(&adev->dev, "platform device creation failed: %ld\n",
> 
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/