linux-kernel - Re: [PATCH v2 2/2] pinctrl: at91: Fix error handling while doing gpiochio_irqchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbx6f-T+20MnGQxKyi6Zpnz3ujipfjwZ+hmnby2EppOtg@mail.gmail.com>
Date:	Tue, 23 Sep 2014 16:47:12 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH v2 2/2] pinctrl: at91: Fix error handling while doing gpiochio_irqchip_add

On Tue, Sep 9, 2014 at 12:20 PM, Pramod Gurav
<pramod.gurav@...rtplayin.com> wrote:

> This patch removes a call to panic function when gpiochio_irqchip_add
> fails and just returns the error to the calling function.
> Same return value is used to handle the error case and adds a lable
> to release resources on error.
> The error message has been improved to indicate failure to add irqchip
> to gpiochip.
>
> This also changes first argument to function at91_gpio_of_irq_setup from
> struct device_node to struct platform_device. Because The device_node
> argument was anyway not being used. Passed pdev so that on failure dev_err
> can use &pdev->dev and log can be associated with proper device.
>
> CC: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> CC: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/