linux-kernel - Re: [PATCH] ARM: qcom: Fix SCM interface for big-endian kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D8A10276-E912-4268-AAB8-48A0C8C7E62D@codeaurora.org>
Date:	Tue, 23 Sep 2014 12:45:25 -0500
From:	Kumar Gala <galak@...eaurora.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	David Brown <davidb@...eaurora.org>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: qcom: Fix SCM interface for big-endian kernels


On Sep 23, 2014, at 12:42 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:

> On 09/23/14 09:47, Kumar Gala wrote:
>> On Sep 22, 2014, at 5:36 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
>> 
>>> The secure environment only runs in little-endian mode, so any
>>> buffers shared with the secure environment should have their
>>> contents converted to little-endian. We also mark such elements
>>> with __le32 to allow sparse to catch such problems.
>>> 
>>> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
>>> ---
>>> drivers/soc/qcom/scm-boot.c |  8 ++++----
>>> drivers/soc/qcom/scm.c      | 34 ++++++++++++++++++----------------
>>> 2 files changed, 22 insertions(+), 20 deletions(-)
>>> 
>>> diff --git a/drivers/soc/qcom/scm-boot.c b/drivers/soc/qcom/scm-boot.c
>>> index 60ff7b482141..3e4d77b371c6 100644
>>> --- a/drivers/soc/qcom/scm-boot.c
>>> +++ b/drivers/soc/qcom/scm-boot.c
>>> @@ -27,12 +27,12 @@
>>> int scm_set_boot_addr(phys_addr_t addr, int flags)
>>> {
>>> 	struct {
>>> -		unsigned int flags;
>>> -		phys_addr_t  addr;
>>> +		__le32 flags;
>>> +		__le32 addr;
>> Hmm, was phys_addr_t wrong here before?  I ask because don’t we support LPAE on some systems?
> 
> Yes it was wrong. It is exactly 32 bits wide.

So we should probably have a patch to fix the interface scm_set_boot_addr() to take a u32 addr instead of a phys_addr_t

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/