linux-kernel - checkpatch: Does anyone care that comments are freeform aligned?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Sep 2014 11:41:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Julia Lawall <julia.lawall@...6.fr>, tapaswenipathak@...il.com,
	opw-kernel@...glegroups.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Carpenter <error27@...il.com>,
	Andy Whitcroft <apw@...onical.com>
Subject: checkpatch: Does anyone care that comments are freeform aligned?

On Wed, 2014-09-24 at 07:47 +0200, Julia Lawall wrote:
> In the following patch extract, one line is indented with spaces rather 
> than tabs.  Is it intentional that checkpatch doesn't complain about this, 
> I guess due to the line being a comment?
[]
>  struct bcm_hdr_suppression_contextinfo {
> -	UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS]; /* Intermediate buffer to accumulate pkt Header for PHS */
> -	UCHAR ucaHdrSuppressionOutBuf[MAX_PHS_LENGTHS + PHSI_LEN]; /* Intermediate buffer containing pkt Header after PHS */
> +    /* Intermediate buffer to accumulate pkt Header for PHS */
> +	UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS];
> +	/* Intermediate buffer containing pkt Header after PHS */
> +	UCHAR ucaHdrSuppressionOutBuf[MAX_PHS_LENGTHS + PHSI_LEN];
>  };

checkpatch does not care when comments start in any
particular position or ensure comments have tabs
preceding them.

Does anyone care?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/