linux-kernel - Re: [PATCH 0/5] x86/PCI: Minor size reduction by marking init code and data as such

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140924072853.GB1768@gmail.com>
Date:	Wed, 24 Sep 2014 09:28:54 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Mathias Krause <minipli@...glemail.com>, linux-pci@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] x86/PCI: Minor size reduction by marking init code
 and data as such


* Bjorn Helgaas <bhelgaas@...gle.com> wrote:

> [+cc x86 folks]
> 
> On Mon, Sep 22, 2014 at 02:27:48PM -0600, Bjorn Helgaas wrote:
> > On Mon, Aug 25, 2014 at 11:26:34PM +0200, Mathias Krause wrote:
> > > Hi Bjorn,
> > > 
> > > this series is a collection of patches trying to mark initialization
> > > code and data of the x86 specific PCI code as such. It also contains
> > > __init annotation cleanups to move them to the spot they belong to
> > > according to include/linux/init.h.
> > > 
> > > The annotation leads to a nice reduction of run-time memory size. At
> > > least two additional pages can be released after initialization which
> > > are otherwise occupied by code and data no longer needed.
> > > 
> > > Please apply!
> > > 
> > > Thanks,
> > > 
> > > Mathias Krause (5):
> > >   x86/PCI: Mark DMI tables as initialization data
> > >   x86/PCI: Move __init annotation were it belongs to
> > >   x86/PCI: Mark constants of pci_mmcfg_nvidia_mcp55() as __initconst
> > >   x86/PCI: Constify pci_mmcfg_probes[] array
> > >   x86/PCI: Mark PCI BIOS initialization code as such
> > 
> > All applied to pci/initdata for v3.18, thanks!
> 
> Oops, I didn't notice that you hadn't cc'd the x86 folks.
> 
> Guys, if these should go through -tip, here's my ack:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> I don't have any other arch/x86 changes in my tree, so I don't care which
> way these go.
> 
> > >  arch/x86/pci/common.c          |   20 ++++++++--------
> > >  arch/x86/pci/mmconfig-shared.c |   40 ++++++++++++++++++--------------
> > >  arch/x86/pci/pcbios.c          |    8 +++----
> > >  3 files changed, 36 insertions(+), 32 deletions(-)

They are looking good to me in principle, and merging them via 
the PCI tree is fine with me as well:

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/