linux-kernel - Re: [PATCH v5] x86, cpu-hotplug: fix llc shared map unreleased during cpu hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54227E6F.6080707@gmail.com>
Date:	Wed, 24 Sep 2014 16:18:55 +0800
From:	Wanpeng Li <kernellwp@...il.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Borislav Petkov <bp@...en8.de>,
	Wanpeng Li <wanpeng.li@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>, hpa@...or.com,
	Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	David Rientjes <rientjes@...gle.com>,
	Prarit Bhargava <prarit@...hat.com>,
	Steven Rostedt <srostedt@...hat.com>,
	Toshi Kani <toshi.kani@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] x86, cpu-hotplug: fix llc shared map unreleased during
 cpu hotplug


于 9/24/14, 3:52 PM, Ingo Molnar 写道:
> * Wanpeng Li <kernellwp@...il.com> wrote:
>
>> 于 14-9-23 下午5:37, Borislav Petkov 写道:
>>> On Wed, Sep 17, 2014 at 03:17:52PM +0800, Wanpeng Li wrote:
>>>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
>>>> IP: [..] find_busiest_group
>>>> PGD 5a9d5067 PUD 13067 PMD 0
>>>> Oops: 0000 [#3] SMP
>>>> [...]
>>>> Call Trace:
>>>> load_balance
>>>> ? _raw_spin_unlock_irqrestore
>>>> idle_balance
>>>> __schedule
>>>> schedule
>>>> schedule_timeout
>>>> ? lock_timer_base
>>>> schedule_timeout_uninterruptible
>>>> msleep
>>>> lock_device_hotplug_sysfs
>>>> online_store
>>>> dev_attr_store
>>>> sysfs_write_file
>>>> vfs_write
>>>> SyS_write
>>>> system_call_fastpath
>>>>
>>>> This bug can be triggered by hot add and remove large number of xen
>>>> domain0's vcpus repeatedly.
>>>>
>>>> Last level cache shared map is built during cpu up and build sched domain
>>>> routine takes advantage of it to setup sched domain cpu topology, however,
>>>> llc shared map is unreleased during cpu disable which lead to invalid sched
>>>> domain cpu topology. This patch fix it by release llc shared map correctly
>>>> during cpu disable.
>>>>
>>>> Reviewed-by: Toshi Kani <toshi.kani@...com>
>>>> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
>>>> Tested-by: Linn Crosetto <linn@...com>
>>>> Signed-off-by: Wanpeng Li <wanpeng.li@...ux.intel.com>
>>> Reviewed-by: Borislav Petkov <bp@...e.de>
>>>
>> Thanks.
>>
>>
>> Ingo, Peter Z, HPA,
>>
>>
>> Could this patch catch up with 3.18 merge window?
> Please also add the real-hardware reports to the changelog.

Just send out the latest version.

Regards,
Wanpeng Li

>
> Thanks,
>
> 	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/