linux-kernel - Re: [PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924094530.GC5811@mwanda>
Date:	Wed, 24 Sep 2014 12:45:30 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: dgap: use dgap_release_remap() in
 dgap_cleanup_board()

On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
>  static void dgap_release_remap(struct board_t *brd)
>  {
> -	release_mem_region(brd->membase, 0x200000);
> -	release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000);
> -	iounmap(brd->re_map_membase);
> -	iounmap(brd->re_map_port);
> +	if (brd->re_map_membase) {

I hate this if conditions.  Let's not complicate dgap_release_remap(),
let's fix the callers instead.  Especially dgap_init_module() is a
totally sucky function with bad unwinding.

Let's not apply this patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/