linux-kernel - Re: [PATCH] mfd: tps65217: add compatible string for subdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924110602.GI19999@lee--X1>
Date:	Wed, 24 Sep 2014 12:06:02 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Johannes Pointner <johannes.pointner@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	AnilKumar Ch <anilkumar@...com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tps65217: add compatible string for subdevices

On Mon, 22 Sep 2014, Johannes Pointner wrote:

> The TPS65217 is missing of_compatible string in the mfd_cell for its
> subdevices. This compatible string is necessary to use functions like
> of_find_backlight_by_node in backlight.c.
> 
> Signed-off-by: Johannes Pointner <johannes.pointner@...automation.com>
> ---
>  Documentation/devicetree/bindings/regulator/tps65217.txt            | 5 ++++-
>  .../devicetree/bindings/video/backlight/tps65217-backlight.txt      | 6 +++---
>  drivers/mfd/tps65217.c                                              | 2 ++
>  3 files changed, 9 insertions(+), 4 deletions(-)

[...]

> diff --git a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> index 5fb9279..c3fb649 100644
> --- a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> +++ b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> @@ -7,18 +7,18 @@ Required properties:
>  - compatible: "ti,tps65217"
>  - reg: I2C slave address
>  - backlight: node for specifying WLED1 and WLED2 lines in TPS65217
> +- compatible: "ti,tps65217-bl"

This is now confusing.  Please make it clear that this part of the
documentation is now referencing the sub-node.

>  - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
>  - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
>  - default-brightness: valid values: 0-100
>  
> -Each regulator is defined using the standard binding for regulators.
> -
>  Example:
>  
>  	tps: tps@24 {
>  		reg = <0x24>;
>  		compatible = "ti,tps65217";
> -		backlight {
> +		tps_bl: backlight {
> +			compatible = "ti,tps65217-bl";
>  			isel = <1>;  /* 1 - ISET1, 2 ISET2 */
>  			fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
>  			default-brightness = <50>;
> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c

This shouldn't be in this patch.

Please adhere to: Documentation/devicetree/bindings/submitting-patches.txt

> index 3cc4c70..77708f9 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -33,9 +33,11 @@
>  static const struct mfd_cell tps65217s[] = {
>  	{
>  		.name = "tps65217-pmic",
> +		.of_compatible = "ti,tps65217-pmic",
>  	},
>  	{
>  		.name = "tps65217-bl",
> +		.of_compatible = "ti,tps65217-bl",
>  	},
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/