lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Sep 2014 13:10:34 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Stefan Agner <stefan@...er.ch> Cc: Alexandre Courbot <gnurou@...il.com>, Shawn Guo <shawn.guo@...escale.com>, Sascha Hauer <kernel@...gutronix.de>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Grant Likely <grant.likely@...aro.org> Subject: Re: [PATCH 3/4] gpio: vf610: add gpiolib/IRQ chip driver for Vybird On Tue, Sep 23, 2014 at 1:51 PM, Stefan Agner <stefan@...er.ch> wrote: > [Me] >> postcore again. I don't like this, can you get rid of it? > > I guess we could load this driver easily a bit later. IMHO, since lots > of other driver use GPIO's, we should it load before all the drivers > gets loaded (before device_initcall). Nope. We use deferred probing to control that today. Ideally all drivers should be device_initcall() and deferred probe be used to order things, not by playing around with initcalls. > Most GPIO driver do this, some statistic again: > $ grep -h -o ".*_initcall" drivers/gpio/*.c | sort | uniq -c | sort -n > -r > 33 subsys_initcall > 14 postcore_initcall > 2 device_initcall > 2 arch_initcall > 1 late_initcall > 1 core_initcall Yeah old legacy. There are patch attacks to get rid of this. The reason we can't just change them is because sometimes dependent drivers do not handle the errorpath very well can can't defer cleanly. With a new driver I expect deferred probe to be used. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists