linux-kernel - Re: [PATCH 0/5] Remove possible deadlocks in nfs_release_page()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924072701.49a70346@tlielax.poochiereds.net>
Date:	Wed, 24 Sep 2014 07:27:01 -0400
From:	Jeff Layton <jeff.layton@...marydata.com>
To:	NeilBrown <neilb@...e.de>
Cc:	Trond Myklebust <trond.myklebust@...marydata.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Ingo Molnar <mingo@...hat.com>,
	linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Layton <jeff.layton@...marydata.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 0/5]  Remove possible deadlocks in nfs_release_page() -
 V3

On Wed, 24 Sep 2014 11:28:32 +1000
NeilBrown <neilb@...e.de> wrote:

> This set includes acked-by's from Andrew and Peter so it should be
> OK for all five patches to go upstream through the NFS tree.
> 
> I split the congestion tracking patch out from the wait-for-PG_private
> patch as they are conceptually separate.
> 
> This set continues to perform well in my tests and addresses all
> issues that have been raised.
> 
> Thanks a lot,
> NeilBrown
> 
> 
> ---
> 
> NeilBrown (5):
>       SCHED: add some "wait..on_bit...timeout()" interfaces.
>       MM: export page_wakeup functions
>       NFS: avoid deadlocks with loop-back mounted NFS filesystems.
>       NFS: avoid waiting at all in nfs_release_page when congested.
>       NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()
> 
> 
>  fs/nfs/file.c                   |   29 +++++++++++++++++++----------
>  fs/nfs/write.c                  |    7 +++++++
>  include/linux/pagemap.h         |   12 ++++++++++--
>  include/linux/wait.h            |    5 ++++-
>  kernel/sched/wait.c             |   36 ++++++++++++++++++++++++++++++++++++
>  mm/filemap.c                    |   21 +++++++++++++++------
>  net/sunrpc/sched.c              |    2 --
>  net/sunrpc/xprtrdma/transport.c |    2 --
>  net/sunrpc/xprtsock.c           |   10 ----------
>  9 files changed, 91 insertions(+), 33 deletions(-)
> 

Cool!

This looks like it'll address my earlier concern about setting the BDI
congested inappropriately. You can add this to the set if you like:

Acked-by: Jeff Layton <jlayton@...marydata.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/