linux-kernel - Re: [PATCH] kvm-vfio: do not use module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5422AEF1.8010008@redhat.com>
Date:	Wed, 24 Sep 2014 13:45:53 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Will Deacon <will.deacon@....com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	Gleb Natapov <gleb@...nel.org>,
	Alex Williamson <Alex.Williamson@...hat.com>
Subject: Re: [PATCH] kvm-vfio: do not use module_init

Il 24/09/2014 13:44, Will Deacon ha scritto:
> On Wed, Sep 24, 2014 at 12:29:09PM +0100, Paolo Bonzini wrote:
>> /me got confused between the kernel and QEMU.  In the kernel, you can
>> only have one module_init function, and it will prevent unloading the
>> module unless you also have the corresponding module_exit function.
> 
> Happy for you to take the blame, but I think this one's my fault!

That's why you were CCed! ;)

>> So, commit 80ce1639727e (KVM: VFIO: register kvm_device_ops dynamically,
>> 2014-09-02) broke unloading of the kvm module, by adding a module_init
>> function and no module_exit.
> 
> I forget kvm builds as a module for other architectures (ie. not arm/arm64).
> 
>> Repair it by making kvm_vfio_ops_init weak, and checking it in
>> kvm_init.
> 
> Hehe, if only there was a kconfig option for kvm-vfio.c...

Yeah, I was tempted to put it back.  What do you think?

Paolo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/