linux-kernel - Re: [PATCH v3] kvm-vfio: do not use module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924121433.GG28823@arm.com>
Date:	Wed, 24 Sep 2014 13:14:33 +0100
From:	Will Deacon <will.deacon@....com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	Gleb Natapov <gleb@...nel.org>,
	Alex Williamson <Alex.Williamson@...hat.com>
Subject: Re: [PATCH v3] kvm-vfio: do not use module_init

On Wed, Sep 24, 2014 at 01:09:28PM +0100, Paolo Bonzini wrote:
> /me got confused between the kernel and QEMU.  In the kernel, you can
> only have one module_init function, and it will prevent unloading the
> module unless you also have the corresponding module_exit function.
> 
> So, commit 80ce1639727e (KVM: VFIO: register kvm_device_ops dynamically,
> 2014-09-02) broke unloading of the kvm module, by adding a module_init
> function and no module_exit.
> 
> Repair it by making kvm_vfio_ops_init weak, and checking it in
> kvm_init.
> 
> Cc: Will Deacon <will.deacon@....com>
> Cc: Gleb Natapov <gleb@...nel.org>
> Cc: Alex Williamson <Alex.Williamson@...hat.com>
> Fixes: 80ce1639727e9d38729c34f162378508c307ca25
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  virt/kvm/kvm_main.c |  4 ++++
>  virt/kvm/vfio.c     |  4 ++--
>  virt/kvm/vfio.h     | 13 +++++++++++++
>  3 files changed, 19 insertions(+), 2 deletions(-)
>  create mode 100644 virt/kvm/vfio.h

Looks good to me, thanks for fixing this:

  Acked-by: Will Deacon <will.deacon@....com>

Will

> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index db57363cc287..499db0977f3c 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -57,6 +57,7 @@
>  
>  #include "coalesced_mmio.h"
>  #include "async_pf.h"
> +#include "vfio.h"
>  
>  #define CREATE_TRACE_POINTS
>  #include <trace/events/kvm.h>
> @@ -3226,6 +3227,9 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align,
>  		goto out_undebugfs;
>  	}
>  
> +	r = kvm_vfio_ops_init();
> +	WARN_ON(r);
> +
>  	return 0;
>  
>  out_undebugfs:
> diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c
> index bb11b36ee8a2..281e7cf2b8e5 100644
> --- a/virt/kvm/vfio.c
> +++ b/virt/kvm/vfio.c
> @@ -18,6 +18,7 @@
>  #include <linux/slab.h>
>  #include <linux/uaccess.h>
>  #include <linux/vfio.h>
> +#include "vfio.h"
>  
>  struct kvm_vfio_group {
>  	struct list_head node;
> @@ -278,8 +279,7 @@ static int kvm_vfio_create(struct kvm_device *dev, u32 type)
>  	return 0;
>  }
>  
> -static int __init kvm_vfio_ops_init(void)
> +int kvm_vfio_ops_init(void)
>  {
>  	return kvm_register_device_ops(&kvm_vfio_ops, KVM_DEV_TYPE_VFIO);
>  }
> -module_init(kvm_vfio_ops_init);
> diff --git a/virt/kvm/vfio.h b/virt/kvm/vfio.h
> new file mode 100644
> index 000000000000..92eac75d6b62
> --- /dev/null
> +++ b/virt/kvm/vfio.h
> @@ -0,0 +1,13 @@
> +#ifndef __KVM_VFIO_H
> +#define __KVM_VFIO_H
> +
> +#ifdef CONFIG_KVM_VFIO
> +int kvm_vfio_ops_init(void);
> +#else
> +static inline int kvm_vfio_ops_init(void)
> +{
> +	return 0;
> +}
> +#endif
> +
> +#endif
> -- 
> 1.8.3.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/