linux-kernel - Re: [GIT PULL] x86 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140924130816.GB3277@gmail.com>
Date:	Wed, 24 Sep 2014 15:08:16 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Matt Fleming <matt.fleming@...el.com>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Roy Franz <roy.franz@...aro.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Josh Boyer <jwboyer@...hat.com>
Subject: Re: [GIT PULL] x86 fixes


* Matt Fleming <matt@...sole-pimps.org> wrote:

> +/*
> + * There's no way to return an informative status from this function,
> + * because any analysis (and printing of error messages) needs to be
> + * done directly at the EFI function call-site.
> + *
> + * For example, EFI_INVALID_PARAMETER could indicate a bug or maybe we
> + * just didn't find any PCI devices, but there's no way to tell outside
> + * the context of the call.
> + */
> +static void setup_efi_pci(struct boot_params *params)

Btw., do we print proper complaints at the EFI call sites if such 
failures do happen (and if that failure is unexpected/bad)?

If that's a given then your patch looks good to me.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/