linux-kernel - [PATCH] Docs: this_cpu_ops: remove redundant add forms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1411566583-22220-1-git-send-email-mark.rutland@arm.com>
Date:	Wed, 24 Sep 2014 14:49:43 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Cc:	Mark Rutland <mark.rutland@....com>,
	Pranith Kumar <bobby.prani@...il.com>,
	Christoph Lameter <cl@...ux.com>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: [PATCH] Docs: this_cpu_ops: remove redundant add forms

Hi,

I spotted the below while trying to figure out how to use this_cpu ops,
and it left me confused for a short while.

I guess that this is a refactoring fallout rather than there being a
special this_cpu_add variant?

Mark.

---->8----
Commit ac490f4dca94 (Documentation: this_cpu_ops.txt: Update description
of this_cpu_ops) added lists of {__,}this_cpu operations, but these have
duplicate, parameter-less entries for {__,}this_cpu_add which don't
correspond to any implementation. No other operations have such
duplicate entries.

Given both are also listed with their full complement of arguments, the
empty forms are redundant and can be removed. This patch performs said
removal.

Signed-off-by: Mark Rutland <mark.rutland@....com>
Cc: Pranith Kumar <bobby.prani@...il.com>
Cc: Christoph Lameter <cl@...ux.com>
Cc: Randy Dunlap <rdunlap@...radead.org>
---
 Documentation/this_cpu_ops.txt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/this_cpu_ops.txt b/Documentation/this_cpu_ops.txt
index 0ec9957..2cbf719 100644
--- a/Documentation/this_cpu_ops.txt
+++ b/Documentation/this_cpu_ops.txt
@@ -41,7 +41,6 @@ The following this_cpu() operations with implied preemption protection
 are defined. These operations can be used without worrying about
 preemption and interrupts.
 
-	this_cpu_add()
 	this_cpu_read(pcp)
 	this_cpu_write(pcp, val)
 	this_cpu_add(pcp, val)
@@ -225,7 +224,6 @@ still occur while an operation is in progress and if the interrupt too
 modifies the variable, then RMW actions can not be guaranteed to be
 safe.
 
-	__this_cpu_add()
 	__this_cpu_read(pcp)
 	__this_cpu_write(pcp, val)
 	__this_cpu_add(pcp, val)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/