linux-kernel - Re: [PATCH v2] ARM: cacheflush: Fix v7_exit_coherency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1409240954220.8647@knanqh.ubzr>
Date:	Wed, 24 Sep 2014 09:54:53 -0400 (EDT)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
cc:	Russell King <linux@....linux.org.uk>,
	Will Deacon <will.deacon@....com>,
	"David A. Long" <dave.long@...aro.org>,
	Mark Rutland <mark.rutland@....com>,
	Vinayak Kale <vkale@....com>,
	Laura Abbott <lauraa@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2] ARM: cacheflush: Fix v7_exit_coherency_flush exynos
 build breakage on ARMv6

On Wed, 24 Sep 2014, Krzysztof Kozlowski wrote:

> This fixes build breakage of platsmp.c if ARMv6 was chosen for compile
> time options (e.g. by building allmodconfig):
> 
> $ make allmodconfig
> $ make
>   CC      arch/arm/mach-exynos/platsmp.o
> /tmp/ccdQM0Eg.s: Assembler messages:
> /tmp/ccdQM0Eg.s:432: Error: selected processor does not support ARM mode `isb '
> /tmp/ccdQM0Eg.s:437: Error: selected processor does not support ARM mode `isb '
> /tmp/ccdQM0Eg.s:438: Error: selected processor does not support ARM mode `dsb '
> make[1]: *** [arch/arm/mach-exynos/platsmp.o] Error 1
> 
> The error was introduced in commit "ARM: EXYNOS: Move code from
> hotplug.c to platsmp.c".  Previously code using
> v7_exit_coherency_flush() macro was built with '-march=armv7-a' flag but
> this flag dissapeared during the movement.
> 
> Fix this by annotating the v7_exit_coherency_flush() asm code with
> armv7-a architecture.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Reported-by: Mark Brown <broonie@...nel.org>
> Link: http://www.spinics.net/lists/linux-samsung-soc/msg36790.html

Acked-by: Nicolas Pitre <nico@...aro.org>


> 
> ---
> 
> Changes since v1:
> 1. Use armv7-a arch annotation instead replacing isb/dsb with macros.
>    Suggsted by Nicolas Pitre.
> ---
>  arch/arm/include/asm/cacheflush.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/include/asm/cacheflush.h b/arch/arm/include/asm/cacheflush.h
> index 79ecb4f34ffb..10e78d00a0bb 100644
> --- a/arch/arm/include/asm/cacheflush.h
> +++ b/arch/arm/include/asm/cacheflush.h
> @@ -466,6 +466,7 @@ static inline void __sync_cache_range_r(volatile void *p, size_t size)
>   */
>  #define v7_exit_coherency_flush(level) \
>  	asm volatile( \
> +	".arch	armv7-a \n\t" \
>  	"stmfd	sp!, {fp, ip} \n\t" \
>  	"mrc	p15, 0, r0, c1, c0, 0	@ get SCTLR \n\t" \
>  	"bic	r0, r0, #"__stringify(CR_C)" \n\t" \
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/