linux-kernel - Re: [PATCH v4 09/10] blk-mq: handle failure path for initializing hctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVMGvW0m-F_SwFgbNzbe8Zbzw4gq6_aLwi-QpyvyxKr=zg@mail.gmail.com>
Date:	Wed, 24 Sep 2014 23:01:00 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Christoph Hellwig <hch@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 09/10] blk-mq: handle failure path for initializing hctx

On Wed, Sep 24, 2014 at 10:17 PM, Jens Axboe <axboe@...nel.dk> wrote:
> On 09/24/2014 04:22 AM, Christoph Hellwig wrote:
>> On Mon, Sep 15, 2014 at 09:11:13PM +0800, Ming Lei wrote:
>>> Failure of initializing one hctx isn't handled, so this patch
>>> introduces blk_mq_init_hctx() and its pair to handle it explicitly.
>>> Also this patch makes code cleaner.
>>>
>>> Signed-off-by: Ming Lei <ming.lei@...onical.com>
>>
>> Looks good,
>>
>> Reviewed-by: Christoph Hellwig <hch@....de>
>>
>> Shouldn't this go to Jens as a separate fix for 3.18?
>
> I think so, doesn't look like it's tied into the series at all.

Without this one, patch 10 becomes quite ugly.

OK, I will split this one from this patchset.

Thank,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/