linux-kernel - Re: [PATCH 2/3] mm: introduce VM_BUG_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5422F9A3.2010303@tilera.com>
Date:	Wed, 24 Sep 2014 13:04:35 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Sasha Levin <sasha.levin@...cle.com>, <akpm@...ux-foundation.org>
CC:	<kirill.shutemov@...ux.intel.com>, <khlebnikov@...nvz.org>,
	<riel@...hat.com>, <mgorman@...e.de>, <n-horiguchi@...jp.nec.com>,
	<mhocko@...e.cz>, <hughd@...gle.com>, <vbabka@...e.cz>,
	<walken@...gle.com>, <minchan@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH 2/3] mm: introduce VM_BUG_ON_MM

On 9/6/2014 3:40 PM, Sasha Levin wrote:
> Very similar to VM_BUG_ON_PAGE and VM_BUG_ON_VMA, dump struct_mm
> when the bug is hit.
>
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>   include/linux/mmdebug.h |   10 +++++++
>   mm/debug.c              |   69 +++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 79 insertions(+)
>
> [...]
> diff --git a/mm/debug.c b/mm/debug.c
> index c19af12..8418893 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> +#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
> +		"tlb_flush_pending %d\n",
> +#endif

Putting the comma that separates the format string from the arguments
inside an ifdef means that if you don't build with NUMA_BALANCING or
COMPACTION you get a compile error.  Perhaps this instead:

+#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
+		"tlb_flush_pending %d\n"
+#endif
-		mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
+		, mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/