linux-kernel - Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Sep 2014 19:06:30 +0200
From:	Michal Simek <michal.simek@...inx.com>
To:	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Michal Simek <michal.simek@...inx.com>
CC:	<linux-arm-kernel@...ts.infradead.org>, <monstr@...str.eu>,
	Josh Cartwright <josh.cartwright@...com>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Rob Herring <robherring2@...il.com>,
	Peter Crosthwaite <peter.crosthwaite@...inx.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC

On 09/24/2014 06:18 PM, Sören Brinkmann wrote:
> On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
>> Add missing reference for ADC node.
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> ---
>>
>>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 772381fe07bb..fc90f47f9c03 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -64,7 +64,7 @@
>>  		interrupt-parent = <&intc>;
>>  		ranges;
>>
>> -		adc@...07100 {
>> +		adc: adc@...07100 {
> I think we enumerated all labels. I.e. 'adc0' is probably better.

I was thinking about it and the reason I didn't use that adc0 was
that it is unique and it is just one in PS. Maybe there could be another adc in PL
but it will be probably automated not to use adc key world.
For PL part names was depending on user description.

Anyway logic was not to use enumerated label for unique IPs.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/