linux-kernel - Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411619466.4026.2.camel@joe-AO725>
Date:	Wed, 24 Sep 2014 21:31:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Elshad Mustafayev <elshadimo@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful
 after a break or return warning

On Wed, Sep 24, 2014 at 11:13:45PM -0400, Elshad Mustafayev wrote:
> > Fixed a coding style issue.
[]
> > diff --git a/kernel/acct.c b/kernel/acct.c
[]
> > @@ -376,9 +376,8 @@ static comp2_t encode_comp2_t(u64 value)
> >  	if (exp > MAXEXP2) {
> >  		/* Overflow. Return largest representable number instead. */
> >  		return (1ul << (MANTSIZE2+EXPSIZE2-1)) - 1;
> > -	} else {
> > -		return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1));
> >  	}
> > +	return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1));
> 
> Just what makes the replacement easier to follow?
> 	if (foo)
> 		return bar;
> 	else
> 		return baz;
> is no less idiomatic than
> 	if (foo)
> 		return bar;
> 	return baz;
> 
> Al, really annoyed by how the words "coding style issue" are getting used as
> a magic incantation...

I agree.

I'll see about updating checkpatch to avoid warning on

	if (foo)
		return bar;
	else
		return baz;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/