linux-kernel - [tip:x86/platform] x86/intel/quark: Add comment on TLB flush to setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Sep 2014 21:54:40 -0700
From:	"tip-bot for Bryan O'Donoghue" <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	pure.logic@...us-software.ie, tglx@...utronix.de
Subject: [tip:x86/platform] x86/intel/quark:
  Add comment on TLB flush to setup_arch()

Commit-ID:  02276a3a677d681f0cd227d7111c71fdbce23832
Gitweb:     http://git.kernel.org/tip/02276a3a677d681f0cd227d7111c71fdbce23832
Author:     Bryan O'Donoghue <pure.logic@...us-software.ie>
AuthorDate: Wed, 24 Sep 2014 21:26:03 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Thu, 25 Sep 2014 06:52:15 +0200

x86/intel/quark: Add comment on TLB flush to setup_arch()

Quark X1000 requires CR3 to be rewritten to flush TLB entries
irrespective of the PGE bits in CR4 or PTE.PGE.

Add a comment to setup_arch() to indicate that the code:

  load_cr3(swapper_pg_dir);
  __flush_tlb_all();

Will already have flushed the TLB @ the CR3 reload allowing us
to skip over a potential if/else for Quark.

Signed-off-by: Bryan O'Donoghue <pure.logic@...us-software.ie>
Link: http://lkml.kernel.org/r/1411590363-8052-1-git-send-email-pure.logic@nexus-software.ie
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/setup.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 41ead8d..e7d7f6e 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -878,6 +878,11 @@ void __init setup_arch(char **cmdline_p)
 			initial_page_table + KERNEL_PGD_BOUNDARY,
 			KERNEL_PGD_PTRS);
 
+	/*
+	 * Locate the page directory and flush the TLB.
+	 * On Quark X1000 rewriting CR3 flushes the TLB no if/else is required
+	 * to choose between __flush_tlb() and __flush_tlb_all()
+	 */
 	load_cr3(swapper_pg_dir);
 	__flush_tlb_all();
 #else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/