linux-kernel - Re: [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <542372FF.4020808@huawei.com>
Date:	Thu, 25 Sep 2014 09:42:23 +0800
From:	Zefan Li <lizefan@...wei.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Kees Cook <keescook@...omium.org>,
	Miao Xie <miaox@...fujitsu.com>,
	"Tetsuo Handa" <penguin-kernel@...ove.SAKURA.ne.jp>,
	LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>,
	"David Rientjes" <rientjes@...gle.com>
Subject: Re: [PATCH v3 1/3] sched: fix confusing PFA_NO_NEW_PRIVS constant

On 2014/9/24 21:35, Tejun Heo wrote:
> On Wed, Sep 24, 2014 at 09:22:18AM -0400, Tejun Heo wrote:
>> On Tue, Sep 23, 2014 at 03:44:19PM +0800, Zefan Li wrote:
>>> From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
>>>
>>> Commit 1d4457f99928 ("sched: move no_new_privs into new atomic flags")
>>> defined PFA_NO_NEW_PRIVS as hexadecimal value, but it is confusing
>>> because it is used as bit number. Redefine it as decimal bit number.
>>>
>>> Note this changes the bit position of PFA_NOW_NEW_PRIVS from 1 to 0.
>>>
>>> Cc: Peter Zijlstra <peterz@...radead.org>
>>> Cc: Ingo Molnar <mingo@...nel.org>
>>> Cc: Miao Xie <miaox@...fujitsu.com>
>>> Cc: Kees Cook <keescook@...omium.org>
>>> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
>>> Acked-by: Kees Cook <keescook@...omium.org>
>>> [ lizf: slightly modified subject and changelog ]
>>> Signed-off-by: Zefan Li <lizefan@...wei.com>
>>
>> Applied 1-3 to cgroup/for-3.17-fixes w/ the typo spotted by davidr
>> fixed.
> 
> Reverted due to build failure.  Will wait for a refreshed version. :(
> 

Didn't notice mm/slab.c uses PF_SPREAD_SLAB without the cpuset wrapper...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/