linux-kernel - Re: linux-stable: backport usb related commit to 3.10 and 3.12?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH6sp9NN1W6VWTuuwRkW2wjhzrXuXf86N6CR67uQKJnShDEvrA@mail.gmail.com>
Date:	Thu, 25 Sep 2014 16:22:26 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	Schrey <debian-kernel@...reyben.de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: linux-stable: backport usb related commit to 3.10 and 3.12?

On Thu, Sep 25, 2014 at 4:20 PM, Frans Klaver <fransklaver@...il.com> wrote:
> On Sat, Aug 23, 2014 at 1:19 PM, Schrey <debian-kernel@...reyben.de> wrote:
>> Greetings.
>>
>> On an administered server, I noticed that there's a constant load
>> around 0.70 when running kernels 3.10 and 3.12, even if
>> the system is doing nothing, and in single user mode.
>> Culprit seems to be the process 'khubd'.
>> No such effect when running kernels 3.4 or 3.14.
>>
>> I reverse bisected linux-stable and found that the following commit
>> fixes it for me, for both kernel 3.10 and 3.12:
>>
>> [08d1dec6f4054e3613f32051d9b149d4203ce0d2] usb:hub set hub->change_bits when
>> over-current happens
>>
>>
>> Could that commit be backported to the stable 3.10 and 3.12 series?
>>
>> (Disclaimer: I'm not a programmer, but I'd be happy to help with any testing
>> involved)
>>
>> Regards
>> Ingmar
>>
>> --------------------------------------------------------------------------
>>
>> $ git diff ac5166bcdb43889a5bd837f5076b78049e1f8bca
>> 08d1dec6f4054e3613f32051d9b149d4203ce0d2
>> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
>> index c1422a0..babba88 100644
>> --- a/drivers/usb/core/hub.c
>> +++ b/drivers/usb/core/hub.c
>> @@ -1147,7 +1147,8 @@ static void hub_activate(struct usb_hub *hub, enum
>> hub_activation_type type)
>>                         /* Tell khubd to disconnect the device or
>>                          * check for a new connection
>>                          */
>> -                       if (udev || (portstatus & USB_PORT_STAT_CONNECTION))
>> +                       if (udev || (portstatus & USB_PORT_STAT_CONNECTION)
>> ||
>> +                           (portstatus & USB_PORT_STAT_OVERCURRENT))
>>                                 set_bit(port1, hub->change_bits);
>>
>>                 } else if (portstatus & USB_PORT_STAT_ENABLE) {
>>
>
> I think this could be eligible for backporting. I

I was going to say: It seems to tick the boxes in
Documentation/stable_kernel_rules.txt.

But then gmail thought it would be a good idea to send out the e-mail.

Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/