linux-kernel - Re: [PATCH] net_dma: fix memory leak in dma_pin_iocvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140925161600.GC1638@intel.com>
Date:	Thu, 25 Sep 2014 21:46:00 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Roman Gushchin <klamm@...dex-team.ru>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages

On Tue, Sep 23, 2014 at 11:27:06PM -0700, Dan Williams wrote:
> On Tue, Sep 23, 2014 at 9:57 PM, Vinod Koul <vinod.koul@...el.com> wrote:
> > On Wed, Sep 03, 2014 at 01:28:59PM +0400, Roman Gushchin wrote:
> >> dma_pin_iovec_pages() calls get_user_pages() for each iovec. If
> >> get_user_pages() returns a number smaller than the requested number,
> >> dma_pin_iovec_pages() calls dma_unpin_iovec_pages(). It releases
> >> previously allocated iovecs, but pages pinned by last get_user_pages()
> >> call remain unreleased.
> >> Fix this by calling put_page() for each such page.
> >>
> > Applied, thanks
> 
> Vinod, I have a patch in my queue that completely removes the remnants
> of NET_DMA.  It's been deprecated for more than a few cycles now
> without any reports to reinstate it.  Time to push the final removal
> patch.  I'll rebase it on top of this so it doesn't collide.

Okay, thanks for update. If you wnat I can remove it, so you don't need to
rebase.

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/