linux-kernel - Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQX0jt2Y8WQ5Ydx4u-3=ewtumcYxn0QhTZR4mRVOv945Fg@mail.gmail.com>
Date:	Thu, 25 Sep 2014 11:23:13 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Joseph Salisbury <joseph.salisbury@...onical.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

On Thu, Sep 25, 2014 at 8:49 AM, Joseph Salisbury
<joseph.salisbury@...onical.com> wrote:
> On 09/16/2014 06:27 PM, Yinghai Lu wrote:
>> On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury
>> <joseph.salisbury@...onical.com> wrote:
>>> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which
>>> is similar to the original bug[1] we discussed.
>>>
>>> Just wondering if there have been any additional ideas on realloc since
>>> this was last discussed?
>>>
>>> [0] http://pad.lv/1363313
>>> [1] http://pad.lv/1245938
>> This one looks different, that LSI card support SRIOV, but BIOS does not
>> allocate resource to SRIOV bar.
>> We release old resource and ...reallocate resource to them with two retries.
>
> The user collected earlydump data, which can be found here:
> https://launchpadlibrarian.net/185141163/dmesg-pci%3Dearlydump

Did you ask the user to test reset_lsi_pci_devices.patch?

> ---
>  drivers/pci/setup-bus.c |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> Index: linux-2.6/drivers/pci/setup-
bus.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/setup-bus.c
> +++ linux-2.6/drivers/pci/setup-bus.c
> @@ -1615,6 +1615,22 @@ again:
>                                                fail_res->flags & type_mask,
>                                                rel_type);
>
> +     /* reset LSI device */
> +     list_for_each_entry(fail_res, &fail_head, list) {
> +             struct pci_dev *pdev;
> +             struct pci_bus *pbus = fail_res->dev->bus;
> +
> +             if (pci_is_root_bus(pbus) || !pbus->self)
> +                     continue;
> +
> +             /* LSI device firmware is not happy with changing BAR value */
> +             list_for_each_entry(pdev, &pbus->devices, bus_list)
> +                     if (pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC) {
> +                             pci_reset_secondary_bus(pbus->self);
> +                             break;
> +                     }
> +     }
> +
>       /* restore size and flags */
>       list_for_each_entry(fail_res, &fail_head, list) {
>               struct resource *res = fail_res->res;

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/