linux-kernel - Re: [PATCH] x86: Quark: Flush TLB via CR3 not CR4.PGE in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542463F4.7010904@nexus-software.ie>
Date:	Thu, 25 Sep 2014 19:50:28 +0100
From:	Bryan O'Donoghue <pure.logic@...us-software.ie>
To:	Ingo Molnar <mingo@...nel.org>,
	Henrique de Moraes Holschuh <hmh@....eng.br>
CC:	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Quark: Flush TLB via CR3 not CR4.PGE in setup_arch()

>> I'd have mentioned "erratum" there, otherwise people won't understand why
>> the PGE bit being set would be a problem in the first place.
>>
>> Something like:
>>
>> /*
>>   * Locate the page directory and flush the TLB.
>>   *
>>   * On Quark X1000 CPUs we still have the PGE bit incorrectly set
>>   * due to a processor erratum, so __flush_tlb_all() is not yet
>>   * doing what it says.  Fortunately we have a cr3 flush here,
>>   * which is what is needed in this processor to flush TLBs, so
>>   * there's no need to add a Quark X1000 quirk here.
>>   */
>
> Yeah.
>
> I'd also add the fact that it's an unintended erratum to the
> Quark quirk section of early_init_intel() as well.

OK.

How about.

/*
   * Locate the page directory and flush the TLB.
   *
   * On Quark X1000 CPUs we still have the PGE bit incorrectly set
   * due to a processor erratum, so __flush_tlb_all() is not yet
   * doing what it says.  Fortunately we have a cr3 flush here,
   * which is what is needed in this processor to flush TLBs, so
   * there's no need to add a Quark X1000 quirk here.
   *
   * early_init_intel will unset the X86_FEATURE_PGE flag later
   * and __flush_tlb_all() will flush via cr3
   */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/