linux-kernel - Re: [PATCH 10/22] ACPI / battery: Replace strnicmp with strncasecmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1916199.r47gMNIv64@vostro.rjw.lan>
Date:	Fri, 26 Sep 2014 01:46:08 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 10/22] ACPI / battery: Replace strnicmp with strncasecmp

On Tuesday, September 16, 2014 10:51:24 PM Rasmus Villemoes wrote:
> The kernel used to contain two functions for length-delimited,
> case-insensitive string comparison, strnicmp with correct semantics
> and a slightly buggy strncasecmp. The latter is the POSIX name, so
> strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper
> for the new strncasecmp to avoid breaking existing users.
> 
> To allow the compat wrapper strnicmp to be removed at some point in
> the future, and to avoid the extra indirection cost, do
> s/strnicmp/strncasecmp/g.
> 
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <lenb@...nel.org>
> Cc: linux-acpi@...r.kernel.org
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Queued up for 3.18, thanks!

> ---
>  drivers/acpi/battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 5fdfe65..8ec8a89 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -695,7 +695,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
>  	if (battery->power_unit && dmi_name_in_vendors("LENOVO")) {
>  		const char *s;
>  		s = dmi_get_system_info(DMI_PRODUCT_VERSION);
> -		if (s && !strnicmp(s, "ThinkPad", 8)) {
> +		if (s && !strncasecmp(s, "ThinkPad", 8)) {
>  			dmi_walk(find_battery, battery);
>  			if (test_bit(ACPI_BATTERY_QUIRK_THINKPAD_MAH,
>  				     &battery->flags) &&
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/