linux-kernel - Re: [PATCH 11/22] cpufreq: Replace strnicmp with strncasecmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2042736.or0GtPEZK6@vostro.rjw.lan>
Date:	Fri, 26 Sep 2014 01:53:12 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 11/22] cpufreq: Replace strnicmp with strncasecmp

On Tuesday, September 16, 2014 02:22:49 PM Viresh Kumar wrote:
> On 16 September 2014 13:51, Rasmus Villemoes <linux@...musvillemoes.dk> wrote:
> > The kernel used to contain two functions for length-delimited,
> > case-insensitive string comparison, strnicmp with correct semantics
> > and a slightly buggy strncasecmp. The latter is the POSIX name, so
> > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper
> > for the new strncasecmp to avoid breaking existing users.
> >
> > To allow the compat wrapper strnicmp to be removed at some point in
> > the future, and to avoid the extra indirection cost, do
> > s/strnicmp/strncasecmp/g.
> >
> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> > Cc: Viresh Kumar <viresh.kumar@...aro.org>
> > Cc: linux-pm@...r.kernel.org
> > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> > ---
> >  drivers/cpufreq/cpufreq.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Not really sure about the implementation of these routines but the
> changes look fine.
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Queued up for 3.18, thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/