linux-kernel - Re: [PATCH v6 0/2] Initial support for XPowers AXP288 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140926071738.GD31272@lee--X1>
Date:	Fri, 26 Sep 2014 08:17:38 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	IIO <linux-iio@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	DEVICE TREE <devicetree@...r.kernel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Carlo Caione <carlo@...one.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Aaron Lu <aaron.lu@...el.com>, Alan Cox <alan@...ux.intel.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh+dt@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Hartmut Knaack <knaack.h@....de>,
	Fugang Duan <B38611@...escale.com>,
	Arnd Bergmann <arnd@...db.de>,
	Zubair Lutfullah <zubair.lutfullah@...il.com>,
	Sebastian Reichel <sre@...ian.org>,
	Johannes Thumshirn <johannes.thumshirn@....de>,
	Philippe Reynes <tremyfr@...oo.fr>,
	Angelo Compagnucci <angelo.compagnucci@...il.com>,
	Doug Anderson <dianders@...omium.org>,
	Ramakrishna Pallala <ramakrishna.pallala@...el.com>,
	Peter Meerwald <pmeerw@...erw.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v6 0/2] Initial support for XPowers AXP288 PMIC

> Can you consider taking this for 3.18 if there are no other issues?

I'm afraid not.  Linus is opening the v3.18 merge-window early this
cycle, so I have stopped applying patches.  This will be re-considered
for v3.19.

> On Thu, 25 Sep 2014 04:15:39 -0700
> Jacob Pan <jacob.jun.pan@...ux.intel.com> wrote:
> 
> > X-Powers AXP288 is a customized PMIC found on some Intel Baytrail-CR
> > platforms. It comes with sub-functions such as USB charging, fuel
> > gauge, ADC, and many LDO and BUCK channels.
> > 
> > By extending the existing AXP20x driver, this patchset adds basic
> > support for AXP288 PMIC with ADC as one MFD cell device driver.
> > 
> > Currently, the PMIC driver in this patchset does not support platform
> > data enumeration. But when ACPI _DSD and unified device properties
> > become available, cell devices with platform data will be added.
> > 
> > This patch does not use intel_soc_pmic core for i2c and regmap
> > handling in that axp288 shares similar programming interface with
> > other X-Power PMICs supported in axp20x.c. Therefore, extending
> > axp20x.c to include axp288 makes more sense.
> > 
> > Changes
> >  v6:	- change axp20x_match_device() flow to give more specific
> > error messages.
> > 	- remove unnecessary cast
> > 
> >  v5:	- excluded iio documentation patch, already applied to
> > iio.git
> >  	- restructured axp288_adc read_raw code to make it more
> > readable
> > 	- renamed adc_enable to adc_set_state and add comment about
> > why adc has to be always on and there is no disable function.
> > 	- axp20x use const as needed for regmap structures
> > 
> >  v4:	- removed rename patch, use Kconfig description to list
> > supported devices
> >  	- misc clean up in ADC code, use regmap_bulk_read and
> > improve error handling, etc.
> > 	- remove IIO ADC scale, treat raw data as processed since the
> > unit is already in IIO expected milliamps.
> > 
> >  v3:	- put all file rename changes in 1/5
> >  	- add iio documentation for in_current_raw/scale
> > 	- removed global variables in axp2xx
> > 	- removed pm callbacks from GPADC
> > 	- removed ACPI opregion cell device
> > 	- added scales to ADC current and voltage
> > 	- removed ADC thermal sensor from sysfs, kernel internal use
> > only
> > 
> >  v2:
> > 	- use format -M for 1/4
> > 	- minor tweak based on Maxime's review
> > 
> > 
> > Jacob Pan (2):
> >   mfd/axp20x: extend axp20x to support axp288 pmic
> >   iio/adc: add support for axp288 adc
> > 
> >  drivers/iio/adc/Kconfig      |   8 +
> >  drivers/iio/adc/Makefile     |   1 +
> >  drivers/iio/adc/axp288_adc.c | 253 ++++++++++++++++++++++++++++++
> >  drivers/mfd/Kconfig          |   3 +-
> >  drivers/mfd/axp20x.c         | 361
> > ++++++++++++++++++++++++++++++++++++-------
> > include/linux/mfd/axp20x.h   |  59 +++++++ 6 files changed, 629
> > insertions(+), 56 deletions(-) create mode 100644
> > drivers/iio/adc/axp288_adc.c
> > 
> 
> [Jacob Pan]

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/