linux-kernel - Re: [PATCH 0/5] HID: wacom: introduce generic HID handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1409261302520.22196@pobox.suse.cz>
Date:	Fri, 26 Sep 2014 13:03:38 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:	Ping Cheng <pinglinux@...il.com>, killertofu@...il.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] HID: wacom: introduce generic HID handling

On Tue, 23 Sep 2014, Benjamin Tissoires wrote:

> Hi guys,
> 
> So, this patch series aims at supporting natively any future HID compliant wacom
> tablet. Those found on the various laptops (ISDv4/5) already are HID compliant
> and they should work in the future without any modification of the kernel.
> 
> Few things to note here:
> - I used the PID 0x00E6 found on the Lenovo X230 for the tests
> - I did not removed its entry in the list because there is a slightly different
>   behavior while using this patch set: when more than two fingers are on the
>   screen, the tablet stops sending finger events, while with the wacom
>   proprietary bits, it continues to send them. Besides that, the events emitted
>   before and after the patch series are the same (at least on the E6)
> - I can not rely on hid-input directly because wacom wants to be in control of
>   the input devices it creates. This might be solved in the future, but for now
>   it is just easier to rewrite the few mapping/events handling than trying to
>   fit in the hid-input model.
> - there will still be more specific use cases to handle later (see the joke of
>   the MS surface 3 pen[1] for instance), but this should give a roughly working
>   pen/touch support for those future devices.
> 
> Jason, I would be very glad if you could conduct a few tests for this on the
> ISDv4/5 sensors you have.

I am waiting with this one for testing results from Jason, but if you guys 
want this to go in the next merge window, I'd like to ask you not to 
postpone the testing too much.

Thanks.

> 
> Cheers,
> Benjamin
> 
> [1] http://who-t.blogspot.com/2014/09/stylus-behaviour-on-microsoft-surface-3.html
> 
> Benjamin Tissoires (5):
>   HID: wacom: rename failN with some meaningful information
>   HID: wacom: split out input allocation and registration
>   HID: wacom: move allocation of inputs earlier
>   HID: wacom: implement generic HID handling for pen generic devices
>   HID: wacom: implement the finger part of the HID generic handling
> 
>  drivers/hid/hid-core.c  |   3 +
>  drivers/hid/wacom.h     |   6 +
>  drivers/hid/wacom_sys.c | 184 +++++++++++++++++++++--------
>  drivers/hid/wacom_wac.c | 299 ++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/hid/wacom_wac.h |  17 +++
>  include/linux/hid.h     |   2 +
>  6 files changed, 462 insertions(+), 49 deletions(-)
> 
> -- 
> 2.1.0
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/