linux-kernel - Re: [PATCH v2] clocksource: Add BE APIs support for clocksource counter reading.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1409261521340.4567@nanos>
Date:	Fri, 26 Sep 2014 15:34:08 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Xiubo Li <Li.Xiubo@...escale.com>
cc:	daniel.lezcano@...aro.org, john.stultz@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clocksource: Add BE APIs support for clocksource
 counter reading.

On Fri, 26 Sep 2014, Xiubo Li wrote:
> For now I just added  _be() support using ioread{16,32}be.
> And i have a check of the clocksource drivers, didn't find anyone
> using LE mode on one BE SoC, so _le() APIs is not needed.

Nonsense. The existing clocksource_mmio accessor function are
providing LE access independent of the CPU endianess. So we don't need
an _le() API simply because we have it already.
 
>  cycle_t clocksource_mmio_readl_up(struct clocksource *c)
>  {
> -	return (cycle_t)readl_relaxed(to_mmio_clksrc(c)->reg);
> +	return (cycle_t)ioread32(to_mmio_clksrc(c)->reg);

And how exactly is this change related to adding BE support?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/