linux-kernel - Re: [PATCH 3/4] slab: fix cpuset check in fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1409261130550.3870@gentwo.org>
Date:	Fri, 26 Sep 2014 11:31:31 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Vladimir Davydov <vdavydov@...allels.com>
cc:	linux-kernel@...r.kernel.org, Li Zefan <lizefan@...wei.com>,
	Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH 3/4] slab: fix cpuset check in fallback_alloc

On Fri, 26 Sep 2014, Vladimir Davydov wrote:

> To avoid this we should use softwall cpuset check in fallback_alloc.

Its weird that softwall checking occurs by setting __GFP_HARDWALL.
>
> Signed-off-by: Vladimir Davydov <vdavydov@...allels.com>
> ---
>  mm/slab.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index eb6f0cf6875c..e35822d07821 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3051,7 +3051,7 @@ retry:
>  	for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) {
>  		nid = zone_to_nid(zone);
>
> -		if (cpuset_zone_allowed(zone, flags | __GFP_HARDWALL) &&
> +		if (cpuset_zone_allowed(zone, flags) &&
>  			get_node(cache, nid) &&
>  			get_node(cache, nid)->free_objects) {
>  				obj = ____cache_alloc_node(cache,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/