linux-kernel - Re: [PATCH] Revert "cgroup: remove redundant variable in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140926042617.GA14426@htj.dyndns.org>
Date:	Fri, 26 Sep 2014 00:26:17 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Zefan Li <lizefan@...wei.com>
Cc:	cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH] Revert "cgroup: remove redundant variable in
 cgroup_mount()"

On Fri, Sep 26, 2014 at 12:03:25PM +0800, Zefan Li wrote:
> This reverts commit 0c7bf3e8cab7900e17ce7f97104c39927d835469.
> 
> If there are child cgroups in the cgroupfs and then we umount it,
> the superblock will be destroyed but the cgroup_root will be kept
> around. When we mount it again, cgroup_mount() will find this
> cgroup_root and allocate a new sb for it.
> 
> So with this commit we will be trapped in a dead loop in the case
> described above, because kernfs_pin_sb() keeps returning NULL.
> 
> Currently I don't see how we can avoid using both pinned_sb and
> new_sb, so just revert it.
> 
> Cc: Al Viro <viro@...IV.linux.org.uk>
> Reported-by: Andrey Wagin <avagin@...il.com>
> Signed-off-by: Zefan Li <lizefan@...wei.com>

Applied to cgroup/for-3.18.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/