linux-kernel - Re: [PATCH] net: optimise inet_proto_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140926.161446.2185318574555478975.davem@davemloft.net>
Date:	Fri, 26 Sep 2014 16:14:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	christophe.leroy@....fr
Cc:	linux-kernel@...r.kernel.org, edumazet@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: optimise inet_proto_csum_replace4()

From: Christophe Leroy <christophe.leroy@....fr>
Date: Tue, 23 Sep 2014 10:54:37 +0200 (CEST)

> csum_partial() is a generic function which is not optimised for small fixed
> length calculations, and its use requires to store "from" and "to" values in
> memory while we already have them available in registers. This also has impact,
> especially on RISC processors. In the same spirit as the change done by
> Eric Dumazet on csum_replace2(), this patch rewrites inet_proto_csum_replace4()
> taking into account RFC1624.
> 
> I spotted during a NATted tcp transfert that csum_partial() is one of top 5
> consuming functions (around 8%), and the second user of csum_partial() is 
> inet_proto_csum_replace4().
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>

Also applied, thanks Christophe.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/