linux-kernel - Re: [PATCH 2/3] pm: add FSM configuration for deep sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140926205153.GY5182@n2100.arm.linux.org.uk>
Date:	Fri, 26 Sep 2014 21:51:53 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Chenhui Zhao <chenhui.zhao@...escale.com>
Cc:	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Zhuoyu.Zhang@...escale.com, Jason.Jin@...escale.com,
	leoli@...escale.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/3] pm: add FSM configuration for deep sleep

On Fri, Sep 26, 2014 at 01:02:01PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 26, 2014 at 07:25:02PM +0800, Chenhui Zhao wrote:
> > +void fsm_write32(void __iomem *addr, u32 val)
> > +{
> > +#ifdef __arm__
> > +	iowrite32be(val, addr);
> > +#endif
> > +
> > +#ifdef __powerpc__
> > +	out_be32(addr, val);
> > +#endif
> 
> The idea of iowrite* is that it should be able to address MMIO or IO
> memory irrespective of the platform.  Why is PowerPC not implementing
> this accessor, or why can't it be used for PowerPC?
> 
> This should just use iowrite32be(), and if it doesn't work on PowerPC,
> PowerPC needs to be fixed.

BenH tells me that this should be able to use iowrite32be() on PowerPC
too without problems, there should be no need to use the older out_be32()
accessors here.  Please can you look into using only iowrite32be() here?

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/