linux-kernel - Re: [PATCH v5 1/2] regulator: st-pwm: get voltage and duty table from dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140927111836.GI27755@sirena.org.uk>
Date:	Sat, 27 Sep 2014 12:18:36 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Chris Zhong <zyw@...k-chips.com>
Cc:	dianders@...omium.org, heiko@...ech.de,
	linux-rockchip@...ts.infradead.org, lee.jones@...aro.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v5 1/2] regulator: st-pwm: get voltage and duty table
 from dts

On Tue, Sep 23, 2014 at 09:42:58PM +0800, Chris Zhong wrote:

> Get voltage & duty table from device tree might be better, other platforms can also use this
> driver without any modify.

Please wrap your changelogs to less than 80 characters.

> diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
> new file mode 100644
> index 0000000..d3f55ea
> --- /dev/null
> +++ b/drivers/regulator/pwm-regulator.c
> @@ -0,0 +1,197 @@
> +/*
> + * Regulator driver for PWM Regulators
> + *
> + * Copyright (C) 2014 - STMicroelectronics Inc.
> + *
> + * Author: Lee Jones <lee.jones@...aro.org>
> + *

Generate patches renaming files with git format-patch -M - as things
stand since this deletes and re-adds the code it's very difficult to
review, it's equivalent to just re-reviewing the driver from scratch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)