linux-kernel - Re: [PATCH] Remove GFP_DMA and GFP_DMA32 from flags before passing it into kmalloc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Sep 2014 16:13:28 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Miles MH Chen <orca.chen@...il.com>
Cc:	Will Deacon <Will.Deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove GFP_DMA and GFP_DMA32 from flags before passing it into kmalloc.

On 27 Sep 2014, at 16:09, Miles MH Chen <orca.chen@...il.com> wrote:
> Signed-off-by: Min-Hua Chen <orca.chen@...il.com>
> ---
>  arch/arm64/mm/dma-mapping.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> index 4164c5a..273cf6d 100644
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -103,7 +103,8 @@ static void *__dma_alloc_noncoherent(struct device *dev, size_t size,
>      ptr = __dma_alloc_coherent(dev, size, dma_handle, flags, attrs);
>      if (!ptr)
>          goto no_mem;
> -    map = kmalloc(sizeof(struct page *) << order, flags & ~GFP_DMA);
> +    map = kmalloc(sizeof(struct page *) << order,
> +                    flags & ~(GFP_DMA | GFP_DMA32));

Do you have an explanation on why this is needed (and such explanation
should also be included in the commit log)? We don’t use ZONE_DMA32 on
arm64 (we did initially but it was for the wrong reasons).

Thanks,

Catalin--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/