linux-kernel - Re: [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function from omap2 dss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140927164554.GA7076@saruman>
Date:	Sat, 27 Sep 2014 11:46:21 -0500
From:	Felipe Balbi <balbi@...com>
To:	Behan Webster <behanw@...verseincode.com>
CC:	<plagnioj@...osoft.com>, <tomi.valkeinen@...com>,
	<daniel.vetter@...ll.ch>, <geert@...ux-m68k.org>,
	<laurent.pinchart@...asonboard.com>, <linux-fbdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<robdclark@...il.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/2] arm, fbdev, omap2, LLVMLinux: Remove nested function
 from omap2 dss

On Fri, Sep 26, 2014 at 06:10:52PM -0700, Behan Webster wrote:
> Replace the use of nested functions where a normal function will suffice.
> 
> Nested functions are not liked by upstream kernel developers in general. Their
> use breaks the use of clang as a compiler, and doesn't make the code any
> better.
> 
> This code now works for both gcc and clang.
> 
> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Cc: Arnd Bergmann <arnd@...db.de>

another one that make sense :-) And probably also deserves
checkpatch/coccinelle/sparse.

Reviewed-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)