linux-kernel - Re: [PATCH 15/15] perf: replace _BSD_SOURCE macro by _DEFAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140928221553.GA22895@drone.musicnaut.iki.fi>
Date:	Mon, 29 Sep 2014 01:15:53 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Alexis Berlemont <alexis.berlemont@...il.com>
Cc:	linux-kernel@...r.kernel.org, jolsa@...hat.com, dsahern@...il.com,
	mingo@...nel.org, sam@...nborg.org, mmarek@...e.cz,
	namhyung@...nel.org
Subject: Re: [PATCH 15/15] perf: replace _BSD_SOURCE macro by _DEFAULT_SOURCE

Hi,

On Mon, Sep 22, 2014 at 11:53:16PM +0200, Alexis Berlemont wrote:
> Starting from glibc-2.20, the macro _BSD_SOURCE is deprecated and
> should be replaced by _DEFAULT_SOURCE.

This patch fixes perf build breakage with glibc-2.20, so _DEFAULT_SOURCE
is needed.

But shouldn't you also keep _BSD_SOURCE still there for a while for
backwards compatibility? (Not sure if it has relevance for those
using older glibcs...).

Anyway to fix the perf + glibc-2.20 build failure:

Tested-by: Aaro Koskinen <aaro.koskinen@....fi>

(BTW, your patch was missing Signed-off-by.)

A.

> ---
>  tools/perf/util/util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index 6686436..f56b4e0 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -38,7 +38,7 @@
>  #define decimal_length(x)	((int)(sizeof(x) * 2.56 + 0.5) + 1)
>  
>  #define _ALL_SOURCE 1
> -#define _BSD_SOURCE 1
> +#define _DEFAULT_SOURCE 1
>  #define HAS_BOOL
>  
>  #include <unistd.h>
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/