linux-kernel - Re: [PATCH] Fixed Conditional white space problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140928225302.GE23926@titan.lakedaemon.net>
Date:	Sun, 28 Sep 2014 18:53:02 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Eric Rost <eric.rost@...abylon.net>, jake@....net,
	antonysaraev@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed Conditional white space problems

On Sun, Sep 28, 2014 at 06:01:01PM -0400, Greg KH wrote:
> On Sun, Sep 28, 2014 at 04:54:26PM -0500, Eric Rost wrote:
> > My first patch, resent to appropriate multiple addresses!
> 
> That's great, but it doesn't belong here in the body of the changelog :)
> 
> > This patch fixes the following checkpatch.pl Warnings:
> > 
> > WARNING: suspect code indent for conditional statements (16, 16)
> > +               for (r = 1; r < 2 * RCNT; r += 2 * SKEIN_UNROLL_512)
> > [...]
> > +               {
> > 
> > WARNING: suspect code indent for conditional statements (16, 16)
> > +               for (r = 1; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
> > [...]
> > +               {
> 
> Your subject should give a clue as to what part of the kernel it
> modifies, for this patch, it might look like:
> 	staging: skein: fixed conditional...
> 
> Care to fix that up and resend?

With Greg's comments addressed,

Acked-by: Jason Cooper <jason@...edaemon.net>

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/