linux-kernel - Re: [PATCH] of: correct of_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACxGe6u+R80oMtF5G5GB4mP316wmuHJROAar4mXfL8fjMM407A@mail.gmail.com>
Date:	Sun, 28 Sep 2014 09:56:20 +0100
From:	Grant Likely <grant.likely@...aro.org>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Rob Herring <robh+dt@...nel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] of: correct of_console_check()'s return value

On Fri, Sep 26, 2014 at 12:53 AM, Brian Norris
<computersforpeace@...il.com> wrote:
> Hi Grant,
>
> On Mon, Sep 08, 2014 at 11:42:38AM +0100, Grant Likely wrote:
>> On Wed,  3 Sep 2014 11:06:43 -0700, Brian Norris <computersforpeace@...il.com> wrote:
>> > The comments above of_console_check() say that it will return TRUE if it
>> > registers a preferred console, but add_preferred_console() uses a
>> > 0-equals-success convention, so ths leaves of_console_check() with an
>> > inconsistent policy for its return values.
>> >
>> > Fortunately, nobody was actually checking the return value of
>> > of_console_check(), so this isn't significant at the moment.
>> >
>> > But let's match the comments, so we're doing what we say.
>> >
>> > Fixes: 3482f2c52b77 ('of: Create of_console_check() for selecting a console specified in /chosen')
>> > Signed-off-by: Brian Norris <computersforpeace@...il.com>
>> > Cc: Grant Likely <grant.likely@...aro.org>
>>
>> Good catch. Applied, thanks.
>
> Applied to what? I don't see it in linux-next.

It got merged into mainline on Thursday.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/