lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Sep 2014 09:25:06 +0000 From: "Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com> To: "broonie@...nel.org" <broonie@...nel.org> CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error. Hi Mark, > Subject: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing > error. > > Since we cannot make sure the 'val_count' will always be none zero > here, and then if it equals to zero, the kmemdup() will return > ZERO_SIZE_PTR, which equals to ((void *)16). > > So this patch fix this with just doing the zero check before calling > kmemdup(). > > Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com> > --- > drivers/base/regmap/regmap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c > index 455a877..3d93e38 100644 > --- a/drivers/base/regmap/regmap.c > +++ b/drivers/base/regmap/regmap.c > @@ -1716,6 +1716,9 @@ out: > } else { > void *wval; > > + if (!val_count) > + return -EINVAL; > + Should it return zero as success or just return -EINVAL for error here ? If it allow zero of val_count in regmap_bulk_write(..., val_count) could do Nothing and just return zero as success at the beginning of it. I will respin this patch if return zero is better ... Thanks, BRs Xiubo > wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL); > if (!wval) { > dev_err(map->dev, "Error in memory allocation\n"); > -- > 2.1.0.27.g96db324 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists