linux-kernel - Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140928103301.GN27755@sirena.org.uk>
Date:	Sun, 28 Sep 2014 11:33:01 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Romain Perier <romain.perier@...il.com>
Cc:	heiko@...ech.de, linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] regulator: act8865: Add support to turn off all
 outputs

On Sat, Sep 27, 2014 at 04:21:44PM +0000, Romain Perier wrote:
> When the property "active-semi,system-power-controller" is found in the
> devicetree, the function pm_power_off is defined. This function sends the
> rights bit fields to the global off control register. shutdown/poweroff
> commands are now supported for hardware components which use these PMU.

We really need to come up with a standard property for this and document
it rather than continuing to add individual device specific properties
all doing the same thing, and probably also some helper code and/or a
standard operation for this - there's a lot of drivers implementing the
same pattern here.

> +	if (dev->of_node &&
> +	    of_property_read_bool(dev->of_node,
> +				  "active-semi,system-power-controller")) {
> +		act8865_i2c_client = client;

Indentation seems messed up here - tabs vs spaces?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)