linux-kernel - Re: [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140929085908.GI12506@ulmo>
Date:	Mon, 29 Sep 2014 10:59:09 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	linux-s390 <linux-s390@...r.kernel.org>,
	"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org,
	sparclinux <sparclinux@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Sam Ravnborg <sam@...nborg.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 6/8] asm-generic/io.h: Implement generic
 {read,write}s*()

On Mon, Sep 29, 2014 at 10:54:34AM +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 13, 2014 at 12:28 PM, Thierry Reding
> <thierry.reding@...il.com> wrote:
> > #ifndef memset_io
> > -#define memset_io(a, b, c)     memset(__io_virt(a), (b), (c))
> > +#define memset_io memset_io
> > +static inline void memset_io(void __iomem *addr, int value, size_t size)
> > +{
> > +       memset(__io_virt(addr), value, size);
> > +}
> >  #endif
> 
> xtensa/allmodconfig:
> 
> include/asm-generic/io.h:820:2: error: implicit declaration of
> function 'memset' [-Werror=implicit-function-declaration]
> include/asm-generic/io.h:829:2: error: implicit declaration of
> function 'memcpy' [-Werror=implicit-function-declaration]
> arch/xtensa/include/asm/string.h:110:14: error: conflicting types for 'memset'
> arch/xtensa/include/asm/string.h:113:14: error: conflicting types for 'memcpy'
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12028900/

I think this can be fixed by including linux/string.h for memset() and
memcpy() in include/asm-generic/io.h.

Thanks,
Thierry

Content of type "application/pgp-signature" skipped