linux-kernel - Re: [PATCH] perf tools: fix build breakage on arm and arm64 targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140929092229.GB20303@arm.com>
Date:	Mon, 29 Sep 2014 10:22:30 +0100
From:	Will Deacon <will.deacon@....com>
To:	Jean Pihet <jean.pihet@...aro.org>
Cc:	Sudeep Holla <Sudeep.Holla@....com>,
	"acme@...hat.com" <acme@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] perf tools: fix build breakage on arm and arm64 targets

On Mon, Sep 29, 2014 at 07:59:59AM +0100, Jean Pihet wrote:
> Hi Will,
> 
> On 26 September 2014 19:19, Sudeep Holla <sudeep.holla@....com> wrote:
> >
> > On 26/09/14 18:01, Will Deacon wrote:
> >>
> >> Attempting to build the perf tool on arm or arm64 targets results in the
> >> following failure:
> >>
> >> arch/arm/util/unwind-libunwind.c: In function ‘libunwind__arch_reg_id’:
> >> arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration of
> >> function ‘pr_err’ [-Werror=implicit-function-declaration]
> >>     pr_err("unwind: invalid reg id %d\n", regnum);
> >>     ^
> >> This is due to commit 84f5d36f4866 ("perf tools: Move pr_* debug macros
> >> into debug object") moving the pr_* macros into a new header file, but
> >> failing to update architectures other than x86.
> >>
> >> This patch adds the missing includes, and fixes the build again.
> 
> The fix for ARM is already in the tip tree at
> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=29a3ce31c38c8f73f4e076b7ffc0876b4f5dd6c3.

Thanks, but that doesn't fix the issue for arm64. I'm also not sure why
these haven't been merged into mainline -- without them, the tool doesn't
even build for arm/arm64 targets.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/