linux-kernel - Re: [PATCH] MIPS: R3000: Fix debug output for Virtual page number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1409290145370.21156@eddie.linux-mips.org>
Date:	Mon, 29 Sep 2014 01:53:08 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Isamu Mogi <isamu@...fytree.jp>
cc:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: R3000: Fix debug output for Virtual page number

On Wed, 10 Sep 2014, Isamu Mogi wrote:

> Virtual page number of R3000 in entryhi is 20 bit from MSB. But in
> dump_tlb(), the bit mask to read it from entryhi is 19 bit (0xffffe000).
> The patch fixes that to 0xfffff000.
> 
> Signed-off-by: Isamu Mogi <isamu@...fytree.jp>

Acked-by: Maciej W. Rozycki <macro@...ux-mips.org>

 It would be good to add appropriate macros to <asm/mipsregs.h> too, to 
avoid magic numbers and decrease the likelihood of issues like this.  As a 
separate change, that is, of course, and not a prerequisite.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/