linux-kernel - Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140929101319.GB1559@katana>
Date:	Mon, 29 Sep 2014 12:13:19 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	Anders Berg <anders.berg@...gotech.com>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

> >+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 
> Error checking on *res*...?
> 
> We should *return* on platform_get_resource() failure..
> 
> >+	base = devm_ioremap_resource(&pdev->dev, res);

Nope. devm_ioremap_resource does that.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)