linux-kernel - Re: [PATCH 6/6] Documentation: Add entry for Spreadtrum's Shark64 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7195852.7nSHtIu8oc@wuerfel>
Date:	Mon, 29 Sep 2014 15:30:34 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	zhang.lyra@...il.com, catalin.marinas@....com,
	gregkh@...uxfoundation.org, ijc+devicetree@...lion.org.uk,
	jslaby@...e.cz, galak@...eaurora.org, broonie@...aro.org,
	mark.rutland@....com, m-karicheri2@...com, pawel.moll@....com,
	artagnon@...il.com, rrichter@...ium.com, robh+dt@...nel.org,
	will.deacon@....com, orsonzhai@...il.com, geng.ren@...eadtrum.com,
	zhizhou.zhang@...eadtrum.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] Documentation: Add entry for Spreadtrum's Shark64 SoC

On Monday 29 September 2014 20:04:53 zhang.lyra@...il.com wrote:
> diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt
> new file mode 100644
> index 0000000..b6dc143
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sprd.txt
> @@ -0,0 +1,6 @@
> +Spreadtrum Platforms Device Tree Bindings
> +----------------------------------------------------
> +
> +Shark64 Board
> +Required root node properties:
> +        - compatible = "sprd,shark64";
> 

Is Shark a board or an SOC? The subject line of the patch and the contents
seem to disagree here.

It's generally better to have the exact SoC product numbers in here, e.g.
"sprd,sc1234", in case we have to apply fixups based on the SoC. You should
also have a board specific string in addition to the SoC-specific one.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/