linux-kernel - Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKzfze9NiOc8_RcOV7RwURKciVCUWY6XyhBk_CsPxTj4r7-q6Q@mail.gmail.com>
Date:	Sun, 28 Sep 2014 19:45:07 -0700
From:	Matt Ranostay <mranostay@...il.com>
To:	Daniel Mack <daniel@...que.org>
Cc:	Kumar Gala <galak@...eaurora.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Daniel Mack <zonque@...il.com>, linux-input@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support

On Sat, Sep 27, 2014 at 11:21 AM, Daniel Mack <daniel@...que.org> wrote:
> On 09/25/2014 07:24 AM, Matt Ranostay wrote:
>> cap1106 driver can support much more one device make the driver
>> generic for support of similiar parts.
>>
>> Signed-off-by: Matt Ranostay <mranostay@...il.com>
>> ---
>>  .../devicetree/bindings/input/cap1106.txt          |  53 ----
>>  .../devicetree/bindings/input/cap11xx.txt          |  54 ++++
>>  drivers/input/keyboard/Kconfig                     |   8 +-
>>  drivers/input/keyboard/Makefile                    |   2 +-
>>  drivers/input/keyboard/cap1106.c                   | 341 ---------------------
>>  drivers/input/keyboard/cap11xx.c                   | 340 ++++++++++++++++++++
>>  6 files changed, 399 insertions(+), 399 deletions(-)
>
> As I've said, such a patch is really a whole lot more readable if you
> use the -M switch for git format-patch to detect renames.
>

TIL I learned of new git format-patch option. Will resubmit v4.

> Other than that, the series now looks good to me. I can't test it,
> however, as I don't have access to the hardware anymore.
>

Yeah I can't confirm it works on cap1106 but there is no reason it
wouldn't work.
Cap1188 works as expected.

Thanks,

Matt

>   Reviewed-by: Daniel Mack <daniel@...que.org>
>
>
>
> Thanks,
> Daniel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/