linux-kernel - Re: [PATCH] pinctrl: st: Fix Sparse error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <542962E6.1000005@st.com>
Date:	Mon, 29 Sep 2014 15:47:18 +0200
From:	Patrice Chotard <patrice.chotard@...com>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>,
	<linux-kernel@...r.kernel.org>
Cc:	Maxime Coquelin <maxime.coquelin@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH] pinctrl: st: Fix Sparse error

Hi Pramod

On 09/29/2014 03:48 PM, Pramod Gurav wrote:
> This change fixes below sparse error,
> drivers/pinctrl/pinctrl-st.c:1515:31: error: incompatible types for operation (>)
> drivers/pinctrl/pinctrl-st.c:1515:31:    left side has type void [noderef] <asn:2>*irqmux_base
> drivers/pinctrl/pinctrl-st.c:1515:31:    right side has type int
>
> The fix is done by removing a check on info->irqmux_base as
> info->irqmux_base has already been checked  for error when allocating it.
> Hence there is no need to redo the check.
>
> Cc: Maxime Coquelin <maxime.coquelin@...com>
> Cc: Patrice Chotard <patrice.chotard@...com>
> CC: Linus Walleij <linus.walleij@...aro.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
> ---
>   drivers/pinctrl/pinctrl-st.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 5475374..ddeaeda 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1512,7 +1512,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
>   					     gpio_irq, st_gpio_irq_handler);
>   	}
>   
> -	if (info->irqmux_base > 0 || gpio_irq > 0) {
> +	if (gpio_irq > 0) {
>   		err = gpiochip_irqchip_add(&bank->gpio_chip, &st_gpio_irqchip,
>   					   0, handle_simple_irq,
>   					   IRQ_TYPE_LEVEL_LOW);


Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/