linux-kernel - [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1411961425-8045-1-git-send-email-Li.Xiubo@freescale.com>
Date:	Mon, 29 Sep 2014 11:30:25 +0800
From:	Xiubo Li <Li.Xiubo@...escale.com>
To:	<akpm@...ux-foundation.org>, <linux-mm@...ck.org>
CC:	<linux-kernel@...r.kernel.org>, <vbabka@...e.cz>,
	<mgorman@...e.de>, <rientjes@...gle.com>, <minchan@...nel.org>,
	Xiubo Li <Li.Xiubo@...escale.com>
Subject: [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly.

Setting 'flags' to zero will be certainly a misleading way to avoid
warning of 'flags' may be used uninitialized. uninitialized_var is
a correct way because the warning is a false possitive.

Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
---
 mm/compaction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 92075d5..59a116d 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -344,7 +344,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
 {
 	int nr_scanned = 0, total_isolated = 0;
 	struct page *cursor, *valid_page = NULL;
-	unsigned long flags = 0;
+	unsigned long uninitialized_var(flags);
 	bool locked = false;
 	unsigned long blockpfn = *start_pfn;
 
@@ -573,7 +573,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
 	unsigned long nr_scanned = 0, nr_isolated = 0;
 	struct list_head *migratelist = &cc->migratepages;
 	struct lruvec *lruvec;
-	unsigned long flags = 0;
+	unsigned long uninitialized_var(flags);
 	bool locked = false;
 	struct page *page = NULL, *valid_page = NULL;
 
-- 
2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/